Maximilian Roos
Maximilian Roos
> Is there a way to disable the header altogether, via e.g. `Settings`? at the moment, the only way is with the binary option. I do think it's worth exploring...
> The current logic means that leading whitespace is handled better for yaml snapshots. What's the benefit of changing this? Couple of reasons: - Currently snapshots are the same for...
OK! I don't think there are any cases that would be worse like this, but if you have any lingering doubts then happy to test them...
Closed in favor of #528
While we wait for a more informed review, one thought (not confident): I notice we add new enums — would there be any case for collapsing "Inline | Named" enums...
Yes those both seem reasonable, though on reflection not obvious changes either. (I note we're handling the contents differently between named string and named binary snapshots — string snapshots we...
> But this is definitely a tradeoff since passing around a `Vec` would make the code simpler and more uniform. I also think and it's unclear whether creating huge binary...
@lasernoises I guess we're still waiting on a review. Not a verdict, but on further reflection, I do think simplifying the code to load snapshots into memory would make sense....
Thanks for resolving the merge conflicts! That must have been a decent amount of work... One note — I've recently spent lots of time simplifying the internals, and I'd be...
OK great! Hopefully it could use at least some of the existing code... One note is that a couple of outstanding PRs change the `SnapshotContents` struct slightly, adding a kind...