Maximilian Roos comments

Results 1454 comments of


                                            Maximilian Roos

Support for more relaxed matching

> deserializing the response into a `serde_json::Value` and then using Insta to compare that to the expected value but doesn't `assert_json_snapshot` work with a `serde_json::Value`? Can you show the `serde_json::Value`...

Support for more relaxed matching

ah, I see what you mean! thanks for the example. I think that's a reasonable ask. but also this would be a big change for insta, since we treat the...

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

What would the method do internally which would be faster than going through pandas? No objection per se, but there would need to be some benefit from adding the method...

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

OK, feel free to post more details when you / someone else has them. We can leave this open for a while; eventually would suggest closing until we have some...

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

> The obvious benefit is performance. OK, I'm not saying this isn't valid, but I am asking how it would be meaningfully more performant. An example showing the improvement would...

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

please feel free to reopen with some empirics on performance improvements (on this specific method; we def believe polars is generally faster than pandas...)

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

anything that gives us some empirical data that this is worth a new method. that could be a full implementation, it could be something as simple as a comparison of...

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

nice! thanks for doing that. one question: if we turn `rechunk=False`, then the effect seems to go away: ```python [ins] In [5]: import numpy as np ...: import pandas as...

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

ok interesting, is the suggestion that xarray should implement the dataframe interface?

Add a `.to_polars_df()` method (very similar to `.to_dataframe()`, which implicitly uses pandas)

does that mean that a dataset / dataarray would be advertising itself as a dataframe, though?