Maximilian Roos
Maximilian Roos
(I adjusted the title as this isn't a simple chore, feel free to adjust further to the extent this stays open)
From this code? ```rust #[cfg_attr(docsrs, doc(cfg(feature = "redactions")))] pub fn sorted_redaction() -> Redaction { fn sort(mut value: Content, _path: ContentPath) -> Content { match value.resolve_inner_mut() { Content::Seq(ref mut val) =>...
OK, I had thought those consistently evaluate to `Equal` given `.unwrap_or(std::cmp::Ordering::Equal)`, but I'm surely missing something
> I think it needs addressing but I'm not convinced that this is the right way to do it. No prob ofc > We have the same problem with leading...
> more than one trailing newline exist How about discriminating between zero and one trailing newline? --- To ensure we're on the same page — at least for file snapshots...
> the leading whitespace is a problem in inline cases because of whitespace removal for indentation handling I would claim newlines in inline snapshots are a very tractable problem: https://github.com/mitsuhiko/insta/issues/457#issue-2169522883...
The latest commit: - Targets the insta version when deciding which env var to use. This lets us support older versions while also using the new env var immediately for...
OK, done. The prior commit actually caught a semantic conflict when running `--force-update-snapshots` on inline snapshots, so made a small change to make that work. This PR ends up being...
Missed the release so changed the 1.39->1.40, 1.40->1.41
Will merge in the next week without more feedback, given the note above, to keep things moving. Lmk if that's too aggressive, both for this PR and the principle