Max Kahnt comments

Results 5 comments of


                                            Max Kahnt

Check just the staged content of the changed files

~I have the opposite behavior: Valid staged changes are not accepted since apparently the working directory is checked instead of the index.~ ~To summarize: I think the "--staged"-flag doesn't work...

Re-instate .lazy(..) to support Mutually Recursive Schemas?

I think I was running into a similar issue when writing a validation generator for OpenApi 3(.1) definitions. I believe the original error can be resolved as described in #2492:...

Type inferred is wrong when using model constructor

I've been proposing the change that apparently creates this issue. I am happy to help out for a bit to see if we find the reason for it and can...

Type inferred is wrong when using model constructor

@lorenzopicoli Thank you for the reproduction example. It helped a lot. Some quick learnings to share: I believe the issue only happens with tsconfig.json's `strictFunctionTypes: true` enabled. Notably, my IDE...

Type inferred is wrong when using model constructor

@lorenzopicoli This fix seems to build against the existing objection test typings, your issue example, and also my codebase :D. There are probably more places in objection's current typings this...