Maximilian Hoffman

Results 64 issues of Maximilian Hoffman

Remove the global async iter queue that is not used by new format. This has little effect on a long-running set of tests or a server that runs multiple tests,...

The LOAD DATA INFILE Enginetests that pass in GMS were never ran against the Dolt integrator. I added skipped `TestLoadData` in `dolt_engine_test.go`.

testing

Below is a specific query that dolt `v0.35.4` plans with three index lookups. In dolt `v.0.40.11` we only plan two lookups and the result is slow to execute. Adding the...

This plan is invalid: ```SQL tmp3> explain select * from b group by x order by x; +---------------------------------------+ | plan | +---------------------------------------+ | GroupBy | | ├─ SelectedExprs(b.x) | |...

re zach: "When we push down an IN clause to the table as an index, we should in principle remove that predicate from the filter. Not having the filter at...

The old count aggregate logic uses `*expression.Star` during evaluation, and explicitly ignores the expression for resolving: ``` func (a *unaryAggBase) Resolved() bool { if _, ok := a.Child.(*expression.Star); ok {...

We appear to push `Sort` nodes below`GroupBy` and `Window` in some cases. In general window functions are responsible for sorting the input buffer once for partitioning, and then a second...

`SHOW CREATE TABLE` prints a schema with `PRIMARY KEY` columns listed in column definition order, when they should be in primary key order: ```SQL dolt sql > create table e...

Version: ``` > dolt version dolt version 0.24.4 ``` Working query: ``` > dolt sql -q " with t as ( select case when p1.pred = p2.actual then 1 else...