go-mysql-server icon indicating copy to clipboard operation
go-mysql-server copied to clipboard

prep counter with failure

Open max-hoffman opened this issue 2 years ago • 1 comments

max-hoffman avatar Jul 28 '22 20:07 max-hoffman

@zachmu If i codegen it, then I have to do it separately for memory_engine_test.go and dolt_engine_test.go, which is probably 2-3 days of automation. You don't think this is a useful stop-gap until we have a bit of time to rework testing?

max-hoffman avatar Jul 29 '22 14:07 max-hoffman

I would hold off on these checks until we can do it a better way

On Fri, Jul 29, 2022, 07:44 Maximilian Hoffman @.***> wrote:

@zachmu https://github.com/zachmu If i codegen it, then I have to do it separately for memory_engine_test.go and dolt_engine_test.go, which is probably 2-3 days of automation. You don't think this is a useful stop-gap until we have a bit of time to rework testing?

— Reply to this email directly, view it on GitHub https://github.com/dolthub/go-mysql-server/pull/1137#issuecomment-1199432201, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADT5FORCF4YGASM4AZVO7LVWPU4FANCNFSM546QSOVA . You are receiving this because you were mentioned.Message ID: @.***>

zachmu avatar Oct 11 '22 06:10 zachmu

Should we just close this?

timsehn avatar Mar 03 '23 22:03 timsehn

Fine w me, the checks in the Dolt repo have worked well enough on their own.

max-hoffman avatar Mar 03 '23 22:03 max-hoffman