Matthias Wolf

Results 15 comments of Matthias Wolf
trafficstars

I'm not quiet sure yet, but this seems a bit overcomplicated and changes to **SmartParamBuilder.cs** aren't really necessary for this to work. I had written something similar a shorter while...

@AndreyAkinshin In my own library, I was also pondering if the wrapper should implement `Equals()` and how far that should go (i.e. also `IEquatable`, etc?). In allmost all cases, BDN...

For these particular tests, and in case of `InProcessEmitToolchain` , have you tried using `GC.GetAllocatedBytesForCurrentThread` instead of `GC.GetTotalAllocatedBytes`? While you can make sure the Jitting and GC threads don't run,...

@AndreyAkinshin Addendum: > have you tried using `GC.GetAllocatedBytesForCurrentThread` instead of `GC.GetTotalAllocatedBytes`? Yeah, that would render the tests meaningless, since the InProcessEmitToolChain starts a thread... (slightly embarrassed) Still, the point remains,...

> We have disabled the xUnit parallelization for these tests: Yes, I know, I did that too. I also included an assertion for that (because I'm paranoid). And I disabled...

While you're at it, there is also this: > Affects: > > ```cs > public static class BenchmarkConverter { > public static BenchmarkRunInfo MethodsToBenchmarks(Type containingType, MethodInfo[] benchmarkMethods, IConfig config =...

> Сheck was added. My bad. I only skimmed through it and didn't realize you've already done it. > > > * For out-of-process jobs, building the auto-generated boilerplate code...

This is how I'm currently doing it for Job columns: https://mawosoft.github.io/Mawosoft.Extensions.BenchmarkDotNet/api/Mawosoft.Extensions.BenchmarkDotNet.JobColumnSelectionProvider.html It's not attribute-based, but relatively simple. And it would be easy to add command line support.

This should IMHO exclude the `Console` Markdown exporter and rely on an escape flag like the existing `EscapeHtml`. I'm reasonably familiar with GitHub Markdown, but not with the other flavors...

This might be of interest: https://github.com/mawosoft/Mawosoft.Extensions.BenchmarkDotNet ```cs using Mawosoft.Extensions.BenchmarkDotNet; // ... ManualConfig config = DefaultConfig.Instance // Assuming benchmarks for multiple runtimes. See the docs for other job column scenarios. .ReplaceColumnCategory(new...