Markus Winter

Results 104 comments of Markus Winter
trafficstars

You can't depend on https://github.com/jenkinsci/jenkins/pull/8866 because this changes AbstractProject and WorkflowJob is not inheriting from it. So no need to change the jenkins version. You would need to also implement...

> Hi @mawinter69 I have tried my best to apply the suggesions from your review. But I might have missed some important details though. If that if the case please...

It would be good to validate the changes against https://github.com/jenkinsci/jenkins/pull/9148 which does a complete rewrite of the history widget

Some questions to think about - make the add/edit description button a secondary button? - should I directly create an overflow button that takes add/edit description? On the run page...

> Like it 👍 > > > * make the add/edit description button a secondary button? > > Seems sensible yeah. > > > * should I directly create an...

I think this is a bug in core. When posting an xml via the rest api or the cli to update a job, the ItemListener is not called, only a...

I opened two PRs in core that will fix the mentioned problems: https://github.com/jenkinsci/jenkins/pull/9304 to fix the issue from JENKINS-64553 which also solves this issue https://github.com/jenkinsci/jenkins/pull/9303 to fix the issue from...

Opened https://github.com/jenkinsci/jenkins/pull/9304 to fix the issue from JENKINS-64553 which also solve this here