Markus Winter

Results 104 comments of Markus Winter
trafficstars

created https://issues.jenkins.io/browse/JENKINS-72988 for the wrong check

> Looks reasonable now. Please file a downstream PR once the incremental is deployed, demonstrating this works as expected, then check > > > For new APIs and extension points,...

Is the code with the `eval` ever reached with modern browser? I think we will always go into this if block `else if(window.JSON && JSON.parse) {` (lines 1064 resp. 1112)

See https://www.jenkins.io/doc/book/platform-information/support-policy-web-browsers/ for which browsers Jenkins supports. Now according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON all browsers that Jenkins supports have a global JSON object and the parse method. So for them `if(window.JSON &&...

I started an epic to remote YUI from Jenkins: https://issues.jenkins.io/browse/JENKINS-73539 The last usage of YUI in core is then addressed by https://github.com/jenkinsci/jenkins/pull/9511 Besides core, I found 38 plugins that make...

> Is the copy option really the best thing as being the one that is directly accessible? So far I never had really the need to copy the logs. But...

https://github.com/jenkins-infra/repository-permissions-updater/issues/4063

I think that when a node is offline it should only affect explicit usage of the node i.e. because it is matched by a label expression in a node step...