Viraj Kanwade

Results 38 comments of Viraj Kanwade

Shouldn't need adding another library for something which could easily be achieved in the base lib

@sigmavirus24 > this has wildly undefined behaviour with the mix of other parameters a user might actually pass. - it is utilizing a function very similar to a function which...

Has anybody been able to run Eclipse on Alpine yet? Could you please share exact steps? Thanks.

Using https://github.com/encode/starlette/blob/b8ea367b4304a98653ec8ce9c794ad0ba6dcaf4b/starlette/middleware/base.py as reference, if I change the function to: ``` class SentryAsgi3Middleware(SentryAsgiMiddleware): """SentryAsgi3Middleware""" # pylint: disable=method-hidden async def __call__(self, scope: Request, receive: Callable[[Request], Awaitable[Response]], send: Callable[[Response], Awaitable[None]]) -> Response:...

Hi @RobertoPrevato Found a sample code for Starlette. Inside the sample asgi3 middleware def __call__: ``` ❯ python app.py ─╯ INFO: Started server process [8701] INFO: Waiting for application startup....

key areas of interest starlette: ``` File "/private/tmp/timing-starlette-asgi-example/.venv/lib/python3.10/site-packages/uvicorn/lifespan/on.py", line 84, in main await app(scope, self.receive, self.send) File "/private/tmp/timing-starlette-asgi-example/.venv/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 75, in __call__ return await self.app(scope, receive, send) File "/private/tmp/timing-starlette-asgi-example/.venv/lib/python3.10/site-packages/starlette/applications.py", line...

starlette: ``` File "/private/tmp/timing-starlette-asgi-example/.venv/lib/python3.10/site-packages/uvicorn/protocols/http/h11_impl.py", line 366, in run_asgi result = await app(self.scope, self.receive, self.send) File "/private/tmp/timing-starlette-asgi-example/.venv/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 75, in __call__ return await self.app(scope, receive, send) File "/private/tmp/timing-starlette-asgi-example/.venv/lib/python3.10/site-packages/starlette/applications.py", line 133, in...

We also need `Mount` support for subrouting.

https://github.com/aws/serverless-application-model/blob/ce2744dfd912d14e431ceb58adab169c8d9849b5/samtranslator/plugins/api/implicit_rest_api_plugin.py#L83 this is the line that restricts it to be pure string.

> Documenting any exceptions like this in the CF reference would help prevent much wasted effort. spent almost half a day trying to investigate why it was failing! Open since...