Rasmus Lilja

Results 19 comments of Rasmus Lilja

I've gone over the PR a few times, and done a lot of testing. All I can find right now is a performance regression with the step details panel resize....

Thanks for all the feedback @ncspost. I'll go over this today. :+1:

@ncspost > Make the canvas bg pattern repeat forever without a border We deemed this out of scope for this iteration, it's not as simple as it seems and a...

@ncspost > Is it possible to display the status of environments built in the alerts? Yes it is, but I don't want to scope creep this PR too much. I...

> When you make a selection and then keyboard through file manager, you get a strange thing where there appear to be two selections. Could we just make the most...

@ncspost > Button text: "Build environment(s)" This doesn't quite make sense when the environments are being built. :thinking: [I think you can add your copywriting suggestions directly here in GitHub](https://egghead.io/lessons/github-add-suggestions-in-a-github-pr-review)....

@ncspost I have fixed all remarks now except for those noted below. > Add numbers to incoming order so users know sort order I had this in the first iteration,...

I mean, it's right there, where we always put the "primary buttons" in the new design: ![image](https://user-images.githubusercontent.com/8259221/184345865-2deb3857-a965-4f10-975a-73f3becff8d5.png)

> When renaming a project, the page needs to be refreshed in order to see the name change. As a user I expected the rename to not go through. This...

> Mouse wheel behavior seems ill-defined. Sometimes using the mouse-wheel will scroll up and down and sometimes it will start zooming in and out. This only happens for me when...