Mauricio G
Mauricio G
@ahumesky are you open to contributions for this. We are open to do the implementation work here - looks like it boils down to just figuring out the equivalent classes...
btw I think you can get away with not doing anything special just by using a custom built r8 (https://partnerissuetracker.corp.google.com/issues/240438146). Thats what we are doing internally. The only problem is...
Hey @ianlewis did this ever get any traction?
PR https://github.com/bazelbuild/rules_kotlin/pull/628 contains a simple repo. `bazel build //repro/src/main/java/com/repro/lib:lib` will throw the following compiler exception ``` ERROR: /Users/mgalindo/Snapchat/Dev/rules_kotlin_repo/rules_kotlin/examples/anvil/repo/src/main/java/com/repo/lib/BUILD.bazel:4:15: KotlinCompile //repo/src/main/java/com/repo/lib:lib { kt: 1, java: 0, srcjars: 0 } for darwin...
> I looked into just using the embeddable compiler (available from Maven) > > It's doable, but comes with some awkward api changes: > > * `com_github_jetbrains_kotlin` would be removed...
> > I looked into just using the embeddable compiler (available from Maven) > > It's doable, but comes with some awkward api changes: > > > > * `com_github_jetbrains_kotlin`...
> So internally I think we're relying on tools like Proguard processing their inputs to discover any `META-INF/proguard` entries, we don't rely on the build system to unpack them and...
> > So internally I think we're relying on tools like Proguard processing their inputs to discover any `META-INF/proguard` entries, we don't rely on the build system to unpack them...
This bit will cause issues with deploy jars https://r8.googlesource.com/r8/+/8c36ac82385e907df2e3166e0534d997a8a418f5/src/main/java/com/android/tools/r8/R8Command.java#1358. If the deploy jar includes artifacts under com.android.tools/ and proguard/ it will ignore stuff under proguard
> This bit will cause issues with deploy jars https://r8.googlesource.com/r8/+/8c36ac82385e907df2e3166e0534d997a8a418f5/src/main/java/com/android/tools/r8/R8Command.java#1358. If the deploy jar includes artifacts under com.android.tools/ and proguard/ it will ignore stuff under proguard @ahumesky I think the...