Maurelian

@b-mueller @thec00n what do you think about this? It's the same as [this BP recco](https://consensys.github.io/smart-contract-best-practices/recommendations/#remember-that-on-chain-data-is-public). It's inherently subjective, and depends on the developers intent, but it's definitely a plausible weakness.

So, what's the conclusion here? It seems like it's a tradeoff between a desire for a well defined and automatable description, vs. a more ambiguous description that maps more closely...

IMO the 'security considerations' section should mention the front running attack that can occur when an allowance is reduced, either by `approve` or the new `permit` function. I don't think...

I like `deadline`, as it solves the problem of worrying about [all the approvals](https://tac.dappstar.io/#/) one has floating out in the world. That said, I am sympathetic to the argument that...

@peroket I didn't realize there was an anchor link for the numerical value of the opcode, that's nice. @Saw-mon-and-Natalie No, I wasn't thinking of it like an API. More like...

Amazing, TY!

@jdourlens I'd say go for it. The code could probably be refactored, and some testing would be nice too if you're keen.

> Which types can be used with `encodePacked` that cannot be used with `bytes.concat`? As a real world example, this use of `encodePacked()`: https://github.com/Anish-Agnihotri/merkle-airdrop-starter/blob/83d6c65d00a10b40e0abdd84a5afa692553a9e72/contracts/src/MerkleClaimERC20.sol#L66 Would need to use casting to...

I approve this, but now that I think about it we really need to have the discipline of writing a test every time we fix a bug. even when it's...

@mergify bump