Matthias Vogelgesang

Results 170 comments of Matthias Vogelgesang

> I feel like wastebin shouldn't alter the content of a file on upload or download Which would mean using the JSON API to POST the data. Hmm … wanted...

It requires users to have Javascript enabled. So far, I tried to use JS only for sugar but not essential functionality.

I will check. Interestingly, the pastebin.com OG also uses form data and I don't think it's a common complaint. Edit: apparently it uses a [different form encoding](https://stackoverflow.com/questions/4526273/what-does-enctype-multipart-form-data-mean).

Try but please also add a test that breaks on the current behavior.

It should be possible to switch to the other encoding, I will give it a shot later tonight.

Can you re-run the test on a single-core machine/VM/container? Just to see the impact of how tokio's background threads deal in such situation compared to a dedicated one.

> Thanks to @qaqland, with a generic call() method we could have performance gain without big refactor work Is it also in your branch? Sorry for being late, this week...

Can you try [this branch](https://github.com/matze/wastebin/tree/improve-perf) and check the results? It's a similar design but uses a bog standard `mpsc` channel. On my system I see even better improvements of around...

> Is that due to CPU difference? Perhaps. I get wildly different results on an i7-13700H (20 threads): 16209.17 (master) vs 24695.38 (mpsc) vs 33287.72 (kanal). And differences become smaller...

One last thing: these huge numbers are of course only possible with an in-memory database. These changes do not do much when the disk is hammered with writes. But in...