Matt, Park
Matt, Park
@facundomedica of course! I'll get the benchmark tomorrow and reply in the PR
Finished benchmarking! Bench marked using existing benchmarking test https://github.com/cosmos/cosmos-sdk/blob/main/types/bench_test.go#L18 on parsing coins. Here are the results: ``` $ benchstat old.txt new.txt goos: darwin goarch: arm64 pkg: github.com/cosmos/cosmos-sdk/types β old.txt β...
@facundomedica Amazing! Thanks so much π So is the claim loop shows approx 75% decrease then regel showing another 75% decrease from there? Also curious about other stats!
Ok, would it make sense if we do the following: - parse amount and string - for loop the dec amount to see if itβs valid - feed the denomination...
Seems like we have reached a consensus here! Will convert this PR to draft until I have made the according changes :)
> Hi @mattverse! While I do think this would be cool, the notion of "crap, I don't have (enough/any) tokens to cover fees for some operation X" is a common...
> here are some tax implications to consider as well though. Consider the case where a user does not want their rewards withdrawn. haha definitely! We want to ensure backward...
@kaito2001 Ah, I was rather referring to https://github.com/osmosis-labs/osmosis/tree/main/tests/localosmosis. Bascially we have dockerized / made it into a command to run a new osmosis locally in the simplest way
@czarcas7ic Yes, that was my understanding of the proposal(That we still allow lockup for any period of time, just that we are not allowing creating incentives of that period) I...
I have no clue why e2e test is failing, will continue to look into this tmrw. I've confirmed that we do not have any incentives related logic in our e2e...