Matt, Park comments

Results 86 comments of


                                            Matt, Park

Update Whitelist for Stargate Query to use Inferred value

@ThanhNhann Please go ahead! This would be an awesome feature to have!

proposal(twap): consider using last spot price instead of zero on error in `getSpotPrices`

Let me think about the possible edge case here, is it going to error when the pool does not have the last spot price? By last spot price, are we...

proposal(twap): consider using last spot price instead of zero on error in `getSpotPrices`

> Currently, we would set the spot price to 0 at t + 1 since it errored. The problem with that is that it negatively impacts the calculations by diverging...

Cleanup Balancer Pools

Updated how we calculate pool share per liquidity for liquidity refund. R4R!

test(x/twap): `afterCreatePool` function

I think it's in the border of unit test vs integration test, where the existing test looks closer to integration test. I do generally feel fine with having a direct...

After create pool test

Gonna leave this open for another day just in case anyone wants further reviews, and then go ahead and merge this

After create pool test

Going ahead to merge this! Thanks for the PR @hieuvubk !

refactor(twap): add sanity check in `updateRecord` to compare `record` time and height against `ctx`

@hieuvubk What causes the error? At a light glance, I don't see anything calling `updateRecord` with in the afterPoolCreation test

Using last spot price instead of zero on error in `getSpotPrices`

assuming that we're putting this in in the upcoming future releases, I'm wondering if there needs to be migration work needed to be done for the existing twap records?

Cannot Estimate Swap in v12

The current EstimateSwap implementation requires the sender account to have balance of the asset you're trying to estimate. This should be getting fixed in the next upgrade, the PR is...