Matthias Seitz

Results 290 comments of Matthias Seitz

Great catch, I tried to debug this, it has definitely something to do with the `%` sign me thinks, try using a `&` instead, that works... What internally happens is...

this would be the same as `browser.new_page("https://jsonip.com")`

afaik `HeapProfiler` is experimental, so I wonder whether it's included in your chromium build.

> Each sevice instance create 8 chromium instances, each request to my service would generate HTML to be render, with debug=true in query string, generated HTML would be respond, without...

I fixed a bug that was related to `Commandchain::poll` in #56 that resulted in timed out requests weren't cleared and `Commandchain::poll` called continuously. Maybe this fixes this issue as well

Can reproduce this. This seems to be an issue with how the newegg site triggers frame navigations. I Could detect a lot of main frame navigations, after the correct one...

This is indeed very cumbersome, but gives the user the most flexibility. However I think it should be easier to take perform the common screenshot tasks, like fullpage, omitbackground etc....

I'm not exactly sure if I understood you correctly. You want to add a custom delay on top a navigation request? Right now there is `Page::wait_for_navigation_response` and `Page::wait_for_navigation` both return...

Right now `wait_for_navigation` waits until the frame is loaded, same as `load` in puppeteer, but it would be fairly easy to add the same options as the puppeteer `wait_for_navigation` function...

Yes, this should generally be straight forward to implement/adapt from `headless_chrome`. Maybe we could include this in the `pdl` generator pipeline since the `Generator` already accepts an option to set...