Matthew J. Sahagian

Results 8 comments of Matthew J. Sahagian

I too would like this feature. The case that I have for it is right at the route level (I'd be open to other ideas), but basically the route is...

@kelunik The router so that the controller/action has reference to what called it. See: https://github.com/hiraeth-php/rad/blob/master/src/AbstractResponder.php#L53

@kelunik That this example only makes use of the request/response from the router is just one example. The reason the router is injected as opposed to the request and response...

@froschdesign I'm not sure I understand the first point regarding StreamInterface. That is, I don't see the relevance with respect to UploadedFile. UploadedFile appears to return ?int (from your own...

@weierophinney Sure, but adding a typehint of `?int ` to `getSize()` will not actually cause an issue when extending SplFileInfo as it predates strict interfaces, that is SplFileInfo says it...

@ADmad I guess people better stop using `rename()` for streams then, since according to the documentation "rename — Renames a file or directory" and a stream is neither of those....

I should add that despite the compatibility changes, this would require a reversion in the IdTokenResponse class to sniff out the available builder. This was previously done here: https://github.com/steverhoades/oauth2-openid-connect-server/commit/6c666441492878de3706c8dc236843f3ae64bf21 I've...