Matt Pavlovich

Test failure cause: ``` java.lang.NoClassDefFoundError: org/osgi/framework/InvalidSyntaxException: org.osgi.framework.InvalidSyntaxException ``` Perhaps the modular bom/osgi dependency changes need to be merged first?

@jbonofre updated a couple dependency scopes as part of osgi-modularity fix in a separate commit.

This should be karaf 4.5.x (or higher) and clearly called out in a Release Notes / Migration Guide. Make a security-related change to the file and _presume_ the extra role...

Is the bug here really the JAAS karaf commands / Encryption Support need to handle the 'group' placeholder better? keys.properties, and ability to support other security providers with a similar...

This is a great idea and useful feature. Esp for other commands that use connection pools, or other stateful resources. One suggestion -- perhaps a rename for consistency? CommandCloseListener?

> Yes, Good point about the name. My only comment is that (potentially) it could be used for other services than commands. But let's start with shell commands :) How...

> @mattrpav I see a use case: a command use a service which starts a thread. The service has to be hook with ssh session to stop the thread when...

@jbonofre please add a test for queue AND topic subscription recovery policy to catch regression

Requested change: 1. Please add getConnectionId() to ConnectionViewMBean The _connectionId_ is the unique value within the broker for the connection. Side note: We should be registering JMX using that unique...

@jeanouii new Jenkins job kicked: https://ci-builds.apache.org/job/ActiveMQ/job/ActiveMQ/view/change-requests/job/PR-1537/