Matt Moore
Matt Moore
/lifecycle frozen
Couple thoughts: --- I'd be cool with trying to split up `GenericCRD` so that what's required is closer (or equal) to `apis.Defaultable` and `apis.Validatable`, in the respective resourcesemantic controllers. It...
Perhaps useful: https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/registry#private-docker-registry-in-kubernetes
/lgtm /approve /unhold 🎉 PKG cut last week, so we have another 5 to roll this back if we have regrets, but let's get it baking.
We should use the shared `drainer` logic, but probably have something that does this over HTTP (no need for TLS)
cc @yanweiguo (community oncall)
I think defining an interface to encapsulate the webhook's needs and having something like the certificate controller implement that as one option would be a welcome refactor (I was talking...
cc @sclevine
Yup, there's no filter passed to genreconciler currently, but you could plumb one through in the controller options.
By "plumbing through" I mean adding a field and calling it from that logic in genreconciler itself, there is no field today.