pkg icon indicating copy to clipboard operation
pkg copied to clipboard

Adopt health checks in sharedmain

Open pmorie opened this issue 5 years ago • 6 comments

Currently, we do not use health checks in our controllers descended from sharedmain. Adopting health checks will allow us to begin reporting controllers as unhealthy so that they are restarted by the kubelet. For example, we will be able to use the leaderelection health checker to begin reporting unhealthy after the leader election timeout elapsed when renewing the leader election lease.

/kind feature

Expected Behavior

Controllers can report themselves as unhealthy so that they can be restarted.

Actual Behavior

That doesn't happen.

pmorie avatar Feb 04 '20 21:02 pmorie

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Aug 24 '20 16:08 github-actions[bot]

/open

afrittoli avatar Oct 20 '20 21:10 afrittoli

/lifecycle frozen

afrittoli avatar Oct 20 '20 21:10 afrittoli

We should use the shared drainer logic, but probably have something that does this over HTTP (no need for TLS)

mattmoor avatar Oct 20 '20 21:10 mattmoor

/assign

I'll take a shot at this.

mpetason avatar Oct 20 '20 21:10 mpetason

Unassigned so someone can resolve this faster than I can.

mpetason avatar Jan 25 '21 19:01 mpetason