Mattijs De Paepe comments

Results 6 comments of


                                            Mattijs De Paepe

#3969 Implement .dockerignore parsing to ignore files when creating temporary work dir

Any update on this?

custom_filter get_pois not working with value True

I believe it is because in the line below, the tag values of `True` aren't added to `filter_keys` nor `data_filter`. If all tag values are True then this is fine...

custom_filter get_pois not working with value True

I see that `overlapping_filter` also plays a part. I think this should be set to True if there are any tags that are set to value True (catch-all) so that...

custom_filter get_pois not working with value True

@Chwiggy could you share the bounding box or area you're using?

custom_filter get_pois not working with value True

@Chwiggy please see my MR for a fix. Your use case works as expected though. It is just because `get_boundaries` adds additional tag key:value combinations as can be seen [here](https://github.com/HTenkanen/pyrosm/blob/master/pyrosm/boundary.py#L7)....

[BUG] MLFlow needs to read .dockerignore and .gitignore or have its own .ignore file

This would be very useful, +1