Matthias Kestenholz

Results 228 comments of Matthias Kestenholz

I'm not sure what you mean by fragment caching. Are you saying that we break the `{% cache %}` template tag in some way?

Thanks, I agree. Besides, if the bug is still there it would come up again.

Hmm, it seems to me that `executemany()` isn't properly supported at all. `def _quote_params` (same file) does not handle a list of lists (or a list of tuples) properly, but...

The import shouldn't be necessary anymore. Just ```python if settings.DEBUG: urlpatterns += [path("__debug__/", include("debug_toolbar.urls"))] ```

No resistance at all, it's just a matter of priorities. I don't see any slowdown related to django-debug-toolbar even on sites with bad amounts of complicated SQL queries. Therefore it's...

@edmenendez Does switching of `PRETTIFY_SQL` help? Do you have a way of profiling this, to find out where most of the time is lost?

Closing because of inactivity. Please resubmit if you still want to work on this.

I'm not sure. I don't know much about `mrbenn` but it doesn't seem to be a widely used package, see https://pypistats.org/packages/mrbenn The package runs a few commands in the background...

It would be interesting to see how you're instantiating the `DashboardView`... it seems that maybe `debug_toolbar.utils.get_name_from_obj` doesn't do the right thing.

Interesting. I see that the module path is correct. `obj.__name__` didn't work for class-based views earlier so maybe something has changed in this area. We might try changing the code...