django-debug-toolbar icon indicating copy to clipboard operation
django-debug-toolbar copied to clipboard

merging a 3rd party package into django-debug-toolbar

Open andytwoods opened this issue 2 years ago • 5 comments

Hi there,

if you felt it a good idea, I'd be happy to merge in the features of this extension into your package: https://github.com/andytwoods/mrbenn

This extension lets you click on a view or template link, and have that view/template open in your IDE. I envision there being a toggle within settings where people can specify if they want this feature.

I would just modify your Template and View tools, adding clickable links. The dedicated toolbar provided by mrbenn would then be unnecessary.

cheers, Andy.

andytwoods avatar Dec 21 '21 16:12 andytwoods

I'm on board with this addition to the TemplatesPanel, @matthiask? It doesn't appear to be a bunch of logic, but rather configuration. It would mean a fair amount of documentation to keep the installation straightforward and quick.

tim-schilling avatar Dec 23 '21 15:12 tim-schilling

I'm not sure. I don't know much about mrbenn but it doesn't seem to be a widely used package, see https://pypistats.org/packages/mrbenn

The package runs a few commands in the background to open files in the IDE, e.g. xdg-open on Linux. I'm slightly against adding code which uses subprocess into the main django-debug-toolbar package.

matthiask avatar Dec 23 '21 16:12 matthiask

Just a heads up that we only released mrbenn perhaps a week ago. Maybe the best option is to wait and see how popular mrbenn becomes.

andytwoods avatar Dec 23 '21 16:12 andytwoods

@andytwoods have you looked into implementing extensions for VSCode and PyCharm? I have no idea what that would look like, but I wonder if we could find a different way to implement this.

tim-schilling avatar Oct 23 '23 00:10 tim-schilling

We've not looked at that possibility. It's a good idea. I'm chock-a-block at the moment so can't explore myself.

andytwoods avatar Oct 23 '23 16:10 andytwoods