Matthias de Baat

Results 45 comments of Matthias de Baat

Design looks good to me. Can't help you with the sensor vs. attribute topic though. If this blocks this PR, I would advise to bump this architecture discussion https://github.com/home-assistant/architecture/discussions/856 or...

Based on our [guidelines](https://design.home-assistant.io/#components/ha-dialogs) some feedback. > Screenshots of how existing logic deals with it: > > ![CleanShot 2024-01-30 at 22 28 32](https://private-user-images.githubusercontent.com/1444314/301030338-4e86dfaf-bc2c-4581-99ef-dd5b697f89c0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY2OTAwMjIsIm5iZiI6MTcwNjY4OTcyMiwicGF0aCI6Ii8xNDQ0MzE0LzMwMTAzMDMzOC00ZTg2ZGZhZi1iYzJjLTQ1ODEtOTllZi1kZDViNjk3Zjg5YzAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDEzMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDAxMzFUMDgyODQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTk4MDU0MDMyNDVmOWIwMDFkYWFhNGM5NGY4Y2FiZjkwZmMxODIzYjE2YjRhYzhjNmEwNmE2NDQwODY4M2FjOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.GuIA8lHJ1XXrN6AvZWE5X9J1spyvT1_ek1PB3fCkLvk) Can you group the `Cancel` and `Next`...

I like this one too! I'm seeing 3 options to select an image, correct me if I'm wrong: - Select a local file using image URL - Upload image from...

> > I like this one too! I'm seeing 3 options to select an image, correct me if I'm wrong: > > > > * Select a local file using...

> I think I would hide the input by default, but allow the user to switch to it with a button I agree. There should be a way to select...

Thanks for your feedback. Based on this I've got something like this in my mind. More details can be found in the [Figma design](https://www.figma.com/file/DvtgSpuwNKQvSIWTvBxTn7/Picture-card-upload-image?type=design&node-id=0%3A1&mode=design&t=tldtNKmfZsYN3gq8-1). ![CleanShot 2023-12-07 at 10 59 49@2x](https://github.com/home-assistant/frontend/assets/20203284/d800c2ea-dec6-467b-b9aa-e13264d24c96)...

In Dutch it's already broken, because the word `geselecteerd` pushes the trash can icon off the screen. ![Schermafbeelding 2024-01-17 om 15 09 27](https://github.com/home-assistant/frontend/assets/20203284/0b4335bf-12a8-4baf-bb31-10061aff6ee1) > Hmm, that sounds a bit strange...

> Is it worth considering a bulk delete as well, or is that too confusing to have with bulk remove in the same set of options? > > No way...

> Maybe don't make it an overflow like we normally have, with 3 dots `...`, but a text button `With selected 🔽 `? Let's keep it with the overflow menu....

> Should we make deletable entities (like helpers) be deleted in the same operation as the current remove button? I would say yes, @karwosts and @bramkragten what do you think?...