frontend
frontend copied to clipboard
Allow adding card from history panel
Breaking change
Proposed change
Allow adding the current selection on the history panel as a card to a dashboard. Re-uses current suggest card logic used on device info page.
Screenshots of how existing logic deals with it:
Error when no data selected
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (thank you!)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Example configuration
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue or discussion:
- Link to documentation pull request:
Checklist
- [ ] The code change is tested and works locally.
- [ ] There is no commented out code in this PR.
- [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
Based on our guidelines some feedback.
Screenshots of how existing logic deals with it:
Can you group the Cancel and Next buttons to the right?
And move the X-icon to the left?
Is there an option to avoid three buttons in one dialog?
Can you add a X-icon to the top left?
Error when no data selected
What will happen when you click OK? Will you get the option to select data? Or does it abort the flow?
@matthiasdebaat these are not new dialogs added in this PR, but already existing dialogs (that should be updated)
@piitaya yeah, that would be a nice addition. Right now we have the statistics card as alternative, but that doesn't work for all entities.


