Matthew McGarvey
Matthew McGarvey
I _think_ it's just a matter of adding a type signature to the `options` parameter https://github.com/luckyframework/lucky/blob/8d7bb5702d92e233c90ae29f743c7780450501af/src/lucky/tags/base_tags.cr#L167-L169 The default arg is `Hash(String, String)` but I'm not entirely sure if that is...
@jwoertink I havent done any experiments but with the way the macro works I believe it would be an extra ten seconds on top of however long webpack takes since...
Checked it again yesterday on Crystal 1.6.0 just to see if it had changed. If anything it has gotten worse. I was seeing over 30 seconds for those two macro...
@jwoertink The action is unrelated to the error. Notice the `Handled by Hierarchy::Products` isn't the same action as the one pasted in. Looks like it's just a compilation error in...
Just spitballing ideas so that there's not just one possibility even if they obviously won't work: ## Class Level Macro Methods ```crystal class IndexPage < BrowserAction status 418 content_type "text/html;...
by chance, did he mean `needs some_content = ->`? It makes more sense to me that he was referring to a default argument that does nothing
I agree that in your case it's not a clean url, but I don't know of any examples where it wouldn't look like that in another framework. Looking into kindmetrics...
Would making the `needs` nilable rather than default to blank strings help? https://github.com/kindmetrics/kindmetrics/blob/66cffa4042a8c9201c1d601a5447d83cb3d95371/src/components/period_dropdown_component.cr#L9-L11
Does it make sense that since Authentic is built on top of lucky that it could also include some test helpers for LuckyFlow? That way the helper can take in...
My thoughts were that there would be an `Authentic::Spec` module and generated apps would have a `require "authentic/spec"` put in the `spec_helper` file which would include anything that would help...