lucky icon indicating copy to clipboard operation
lucky copied to clipboard

Add helpful error when using select_tag with an attribute

Open paulcsmith opened this issue 4 years ago • 2 comments

https://gitter.im/luckyframework/Lobby?at=5e635af4afdc1e2033d6540a

The error isn’t helpful so we should have a more helpful one saying to use select_input with an attribute

paulcsmith avatar Mar 07 '20 13:03 paulcsmith

lol https://github.com/luckyframework/lucky/issues/985

jwoertink avatar Mar 08 '20 00:03 jwoertink

I think it's just a matter of adding a type signature to the options parameter https://github.com/luckyframework/lucky/blob/8d7bb5702d92e233c90ae29f743c7780450501af/src/lucky/tags/base_tags.cr#L167-L169

The default arg is Hash(String, String) but I'm not entirely sure if that is always how people use it

matthewmcgarvey avatar Apr 13 '21 01:04 matthewmcgarvey