Matt Mayer
Matt Mayer
You should make a matching issue for this PR so that we can gauge user interest for the new feature. New methods (as opposed to new translations for existing methods)...
> Why it fails? you need to add a JSDoc to the new method, with at least `@example` and `@since` tags
> @matthewmayer What should I write `since`? doesn't really matter. any future version e.g. 8.2.0 or 9.0.0. If the issue gets upvoted enough to be approved the PR would be...
What about passing a refDate 5 years in the future?
Logically if this was added there would need to be equivalent paramters for recent(), past() , soon(), and future() as they are symmetrical.
Probably also worth checking if genrandRes53CC is significantly slower, or if there are any other downsides to using it.
I think this should be probably considered a breaking change given it causes nearly every snapshot to change. That would also allow for beta testing of the change before 9.0...
Could we still allow access to the original 32-bit Mersenne generator via the new #2195 feature? Then if someone prefers the original implementation (e.g. if speed is more importrant than...
Speed. You said this implementation is twice as slow? So if I'm generating millions of fake names I don't want it to be slower than before.
While it looks like a very nice library it's also maintained by one person. Given the history of the project Faker deliberately has many maintainers (and currently no dependencies).