faker icon indicating copy to clipboard operation
faker copied to clipboard

feat(module): add new notations module for science

Open CoolPlayLin opened this issue 1 year ago • 7 comments

  • Resolve #2416

CoolPlayLin avatar Sep 23 '23 05:09 CoolPlayLin

You should make a matching issue for this PR so that we can gauge user interest for the new feature. New methods (as opposed to new translations for existing methods) generally need several 👍 before they are considered for inclusion.

matthewmayer avatar Sep 23 '23 06:09 matthewmayer

Why it fails?

CoolPlayLin avatar Sep 23 '23 12:09 CoolPlayLin

Why it fails?

you need to add a JSDoc to the new method, with at least @example and @since tags

matthewmayer avatar Sep 23 '23 13:09 matthewmayer

@matthewmayer What should I write since?

CoolPlayLin avatar Sep 23 '23 13:09 CoolPlayLin

@matthewmayer What should I write since?

doesn't really matter. any future version e.g. 8.2.0 or 9.0.0. If the issue gets upvoted enough to be approved the PR would be adjusted later to match the correct release version.

matthewmayer avatar Sep 23 '23 13:09 matthewmayer

done

CoolPlayLin avatar Sep 23 '23 13:09 CoolPlayLin

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 99.57%. Comparing base (871b2b0) to head (eda18b7). Report is 270 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2415      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2808       +1     
  Lines      250452   250535      +83     
  Branches     1151     1151              
==========================================
+ Hits       249386   249465      +79     
- Misses       1038     1042       +4     
  Partials       28       28              
Files Coverage Δ
src/locales/en/science/index.ts 100.00% <100.00%> (ø)
src/locales/en/science/notation.ts 100.00% <100.00%> (ø)
src/modules/science/index.ts 100.00% <100.00%> (ø)
src/definitions/science.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

codecov[bot] avatar Sep 23 '23 14:09 codecov[bot]