Matt Mayer
Matt Mayer
While I think there are a few special cases that need their own PRs like unique and the image providers, I think it's fine if most of the standard removals...
Yes, I think I need some help implementing your suggestions
> lets just assume nobody is checking for the explicit error message in a catch block 😏 i think we can assume thats brittle enough to not be considered breaking...
> @matthewmayer Does the change look good to you? > > Ready for review. looks good for me. i can't approve as its my own PR
How about this, shows quoted strings, unquoted strings, and JSON ```faker.helpers.fake('My sister {{person.firstName(female)}} and my brother {{person.firstName("male")}} live at {{location.streetAddress({ "useFullAddress": true })}}')```
What if the symbol, symbol position and default decimal places came from the locale settings instead?
My feeling is if you remove the currency symbol this is not different enough to faker.number.float
We'll need rebase after https://github.com/faker-js/faker/pull/2712 lands
Nope sorry not WIP any more. Ready for final review.
This could potentially be localizable for example have faker.company.number() And then for the es locale it gives a CIF, for the en_GB locale it gives a UK Company number etc.