faker icon indicating copy to clipboard operation
faker copied to clipboard

feat(number): add multipleOf to faker.number.int

Open matthewmayer opened this issue 1 year ago • 1 comments

fix #2584

matthewmayer avatar Dec 24 '23 11:12 matthewmayer

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.57%. Comparing base (1169a05) to head (3bcbd63).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2586      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        3034     3034              
  Lines      250434   250453      +19     
  Branches      627      986     +359     
==========================================
+ Hits       249375   249380       +5     
- Misses       1030     1073      +43     
+ Partials       29        0      -29     
Files Coverage Δ
src/modules/number/index.ts 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

codecov[bot] avatar Dec 24 '23 11:12 codecov[bot]

@matthewmayer What is the status on this PR? Can we help you?

ST-DDT avatar Mar 04 '24 18:03 ST-DDT

Yes, I think I need some help implementing your suggestions

matthewmayer avatar Mar 05 '24 00:03 matthewmayer

@matthewmayer Does the change look good to you?


Ready for review.

ST-DDT avatar Mar 11 '24 23:03 ST-DDT

lets just assume nobody is checking for the explicit error message in a catch block 😏

i think we can assume thats brittle enough to not be considered breaking https://xkcd.com/1172/

matthewmayer avatar Mar 12 '24 07:03 matthewmayer

@matthewmayer Does the change look good to you?

Ready for review.

looks good for me. i can't approve as its my own PR

matthewmayer avatar Mar 12 '24 07:03 matthewmayer