Matthew Elwell comments

Results 347 comments of


                                            Matthew Elwell

Uncaught rejected promise when attempting to fetch flags while offline

Hi @frankieyan, thanks for raising this. I think your suggestion here makes sense > handle the rejection and only reject from init() if the cache fails Would you be willing...

Ability to assign a default organization to a new user logged in via google SSO

Thanks @nishant-shah-social , I agree that this would be useful functionality. We would love to receive a PR if you're willing to do so.

Ability to assign a default organization to a new user logged in via google SSO

Closing this as stale. Users can and should be added via invites.

"Change Email Address" requires a password, but not all users have one

Related PR for a similar change to delete account: #3693

"Change Email Address" requires a password, but not all users have one

@existentialcoder I'm not sure that will work all that well since a user that wants to change their email address, but had previously auth'd with Google / Github quite probably...

Identity Override Stays After Identity is Deleted

This has been fixed in a recent release.

onError not called if cacheFlags is true and api is not reachable

@kyle-ssg this sounds very similar to [this](https://github.com/Flagsmith/flagsmith-js-client/issues/347) - is it a duplicate?

Deadlock occurs for flag value fetching while using in memory or redis cache for flags

@Aniketsingh1 I'm sorry, I don't quite follow this issue. It looks like you have built your own caching implementation so I'm not sure how this relates to our SDK? Could...

Consider adding some means for the caller to know whether the request was from cache or not

Hi @mjwills-k, thanks for raising this. I certainly think it sounds sensible, but it's not something that we'll be able to get to any time soon I'm afraid.

Add an $requestTimeoutSeconds option

Hi @predrag-nikolic-kombinat-dev, thanks for raising this. I'd rather just allow the user to provide their own HTTP client, rather than exposing individual config options for the client as additional parameters...