Matthew Elwell
Matthew Elwell
@devapro just checking in to see if you had time to look at my recent review comments and whether you might have time to update the PR?
>I think will be good to add test that checks case when db is not called, but my knowledge in python very limited, I didn't find an example of how...
Converting this to draft while I work out how to handle this better with regards to change requests in particular.
Closing as PR will change signficantly
My preference for the implementation is (1) as I am keen to get transient traits out there ASAP. It also gives us some time to perfect the implementation and, if...
A few comments on the schema: 1. I see that `Traits` is an object. Should this be a list? 2. I see that `environment` is required, since the evaluation context...
> A few comments on the schema: > > 1. I see that `Traits` is an object. Should this be a list? > 2. ~I see that `environment` is required,...
Thanks for raising this @BioSurienDG . We'll take a look into it and get it fixed up.
@novakzaballa can you add more context on this one please?
@sumtzehern I am unable to reproduce this behaviour, please can you provide further steps to reproduce this.