Matthew Birtch
Matthew Birtch
> @matthewbirtch thanks - I don't see any of my comments addressed/fix applied yet see comment [here](https://github.com/mattermost/mattermost-webapp/pull/11152#issuecomment-1278158365), additionally e2e tests are broken due to changes in this PR > >...
> For Quote button, I was thinking instead of showing a seperate Quote button, does make sense to add this option to dot (...) menu, similar to GitHub experience. Probably...
> Would you feel comfortable reviewing and merging the PR before we merge this, or should we look at manually setting up a test server with both of these branches...
> > 2. For the search results empty state, can we use proper `“` and `”` characters for the search term? > > @matthewbirtch Are you mentioning quote style, I...
> One question for UX @matthewbirtch the new graphic in dark themes doesn't show the icon "shadow" as it does in light theme. Is that ok? Yes, @jgilliam17 this is...
> 4\. The ... menu on a voice message doesn't seem to do anything. Did we have thoughts about what we'd offer in there? I think at least having two...
Thanks for the contribution @sinansonmez. A couple suggestions from me: 1. I wonder if we should make the menu item `dangerous` style like we do in the Channel menu: 2....
Good question @sinansonmez. I think that's a good suggestion and would make sense to treat it similarly I think.
@sinansonmez I think we should be able to re-use the same modal that shows (and it's language) when you try to leave a Private channel from the main channel menu....
> Thanks @sinansonmez Tested, looks great. Just one small issue - for channel admin, option to leave the channel is tucked slightly under managing members section. @jgilliam17 I assume this...