mattermost-webapp icon indicating copy to clipboard operation
mattermost-webapp copied to clipboard

Published 20 hours ago • verified publisher icon mattermost

[MM 40414] : Update empty states to align with new branding and changes in empty state copy

Open VishakhaPoonia opened this issue 2 years ago • 53 comments

Summary

Update empty states to align with new branding and changes in empty state copy

Ticket Link

Fixes https://github.com/mattermost/mattermost-server/issues/19325 Fixes https://mattermost.atlassian.net/browse/MM-40414

Related Pull Requests

n/a

Screenshots

Screenshot 2022-04-04 at 12 53 54 AM Screenshot 2022-04-04 at 12 55 16 AM Screenshot 2022-04-04 at 12 53 43 AM Screenshot 2022-04-04 at 12 53 35 AM Screenshot 2022-04-04 at 12 53 26 AM Screenshot 2022-04-04 at 12 53 17 AM Screenshot 2022-04-04 at 12 52 59 AM Screenshot 2022-04-04 at 12 53 08 AM Screenshot 2022-04-25 at 12 43 26 PM Screenshot 2022-04-25 at 12 44 18 PM

Release Note

UI: Empty state icons changes and related text copy changes.

VishakhaPoonia avatar Mar 22 '22 04:03 VishakhaPoonia

@VishakhaPoonia: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

mm-cloud-bot avatar Mar 22 '22 04:03 mm-cloud-bot

Hello @VishakhaPoonia,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mattermod avatar Mar 22 '22 04:03 mattermod

Thanks for the PR, @VishakhaPoonia! Let us know if you have any questions or if there's anything we can help with. I did notice that there's some likely-unintentional style changes that are making CI complain, but those obviously don't need to be fixed until this is ready for review.

hmhealey avatar Mar 23 '22 14:03 hmhealey

@VishakhaPoonia thanks for the PR! Is it ready for review?

esethna avatar Mar 31 '22 17:03 esethna

@esethna No there are few changes left will try to close those today. Thanks

VishakhaPoonia avatar Apr 03 '22 05:04 VishakhaPoonia

@esethna Pr is ready for review, Thanks for waiting.

VishakhaPoonia avatar Apr 03 '22 19:04 VishakhaPoonia

  1. For the search results empty state, can we use proper “ and ” characters for the search term?

@matthewbirtch Are you mentioning quote style, I checked in Figma you are using Metropolis font, in code we are using the same font. I can think of 2 scenarios

  1. Either only name is same and font used here and in Figma are different,
  2. Font isn’t getting downloaded.
Screenshot 2022-04-05 at 9 16 54 AM

VishakhaPoonia avatar Apr 05 '22 03:04 VishakhaPoonia

  1. For the search results empty state, can we use proper “ and ” characters for the search term?

@matthewbirtch Are you mentioning quote style, I checked in Figma you are using Metropolis font, in code we are using the same font. I can think of 2 scenarios

  1. Either only name is same and font used here and in Figma are different,
  2. Font isn’t getting downloaded.

The font is correct - that's not the problem. You just need to update the quote characters to change from using " to proper opening and closing quote marks “ and ”

matthewbirtch avatar Apr 05 '22 14:04 matthewbirtch

Adding @AshishDhama for a second dev review

esethna avatar Apr 11 '22 19:04 esethna

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar Apr 23 '22 01:04 mattermod

@hmhealey Have updated the Pr, please take look.

VishakhaPoonia avatar Apr 25 '22 04:04 VishakhaPoonia

/test-e2e

AshishDhama avatar Apr 25 '22 07:04 AshishDhama

I haven't taken a super deep look on this, but I'll trust @larkox and @AshishDhama's judgment here, so I'll say it looks good to me 😄

hmhealey avatar Apr 25 '22 15:04 hmhealey

/e2e-test

hmhealey avatar Apr 25 '22 15:04 hmhealey

cc// @jgilliam17 for QA review

esethna avatar Apr 25 '22 18:04 esethna

Thanks @VishakhaPoonia Tested manually and changes look good. One question for UX @matthewbirtch the new graphic in dark themes doesn't show the icon "shadow" as it does in light theme. Is that ok? Screen Shot 2022-04-25 at 4 26 27 PM Screen Shot 2022-04-25 at 4 26 12 PM

Quite a few E2Es are failing due to wording changes pinned posts > pinned messages, save > save message etc. Can you please take a look and fix the failing tests? Thanks 🙂

jgilliam17 avatar Apr 25 '22 20:04 jgilliam17

One question for UX @matthewbirtch the new graphic in dark themes doesn't show the icon "shadow" as it does in light theme. Is that ok?

Yes, @jgilliam17 this is expected.

matthewbirtch avatar Apr 25 '22 22:04 matthewbirtch

Removing cloud test server for maintenance reasons. Please feel free to add it again if needed.

stylianosrigas avatar May 04 '22 09:05 stylianosrigas

@VishakhaPoonia Let me know if you need any help with E2Es that failed due to the changes in this PR.

jgilliam17 avatar May 05 '22 19:05 jgilliam17

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

mattermod avatar May 16 '22 01:05 mattermod

@VishakhaPoonia let us know if you're still working on this?

esethna avatar May 16 '22 22:05 esethna

@VishakhaPoonia are you able to help with teh E2E's? This PR is really close, I'd love to get it across the finish line!

esethna avatar Jun 21 '22 18:06 esethna

@esethna Yeah I will take care of this weekend, Thanks for the reminder.

VishakhaPoonia avatar Jun 22 '22 10:06 VishakhaPoonia

/update-branch

AshishDhama avatar Jul 12 '22 07:07 AshishDhama

@VishakhaPoonia I will handle the E2e tests so we can merge this this week. Really appreciate the work you did for this feature 💯

nevyangelova avatar Jul 13 '22 16:07 nevyangelova

Thanks @nevyangelova!

esethna avatar Jul 13 '22 21:07 esethna

@nevyangelova thanks @nevyangelova for the help, I do have some progress either I will create a new pr or update this one by tomorrow. If that will work.

VishakhaPoonia avatar Jul 14 '22 13:07 VishakhaPoonia

@nevyangelova thanks @nevyangelova for the help, I do have some progress either I will create a new pr or update this one by tomorrow. If that will work.

ok we can wait no worries.

nevyangelova avatar Jul 14 '22 15:07 nevyangelova

@nevyangelova thanks @nevyangelova for the help, I do have some progress either I will create a new pr or update this one by tomorrow. If that will work.

@VishakhaPoonia thanks for the great work - please keep us posted on this!

rmonga71 avatar Jul 18 '22 13:07 rmonga71

@nevyangelova have updated test cases, if you can take a look I am very new to e2e

VishakhaPoonia avatar Jul 18 '22 16:07 VishakhaPoonia