Matthew Christopher

Results 378 comments of Matthew Christopher

> > ``` > > "type": "boolean", > > ``` > > Please consider moving to string enum for these kinds of properties. ARM review prefers enum over booleans for...

Yes, I've started a thread internally on if we just want to swap to using enums for this pattern going forward. I think we can have a discussion internally on...

> > ``` > > } > > ``` > > consider updating these to enum as explained here : > > https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md > > Refers to: specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-11-02-preview/managedClusters.json:7243 in [5aefecb](https://github.com/Azure/azure-rest-api-specs/commit/5aefecbe32408d68e731023417158b347cc0c1f2)....

I was also having this same problem. It took me longer than I care to admit to realize that I had a trailing `\n` character in the FIC issuer which...

I am not sure what the right solution to this issue is, but interested in folks thoughts. I do think that the ability to use ASO to provision a Managed...

> This seems simpler to understand and use than allowing type-specific overrides specific to each Make() call. It's probably slightly simpler to understand and probably moderately simpler to implement (doing...

> By the way, how much of your problem will be solved if rapid would have built-in time.Time generators? There are two things causing `Make` to panic from my large...

yes, I believe that it would. I have a similar change that I was prototyping [here](https://github.com/matthchr/rapid/commit/a334a789c4539bc041d8fdf02e58a31a770665c3) but got sidetracked and never finished it.

> Apologies for not search through the issues before opening the pull request. @matthchr if you have any requests/suggestions/feedback on the linked PR I'm all ears. No apologies needed! I...