Matteo Depalo
Matteo Depalo
Hi @Klem3n, thank you for opening this issue. We've put it in our backlog and will report back when we have a fix.
After creating this issue I noticed that this doesn't happen just on exit, it happens even without it. I've updated the issue.
>Could you elaborate why we need to unref() in the first place? I'm wondering if it's going to have other side effects, in case other code outside of Ink depends...
To me that change isn't breaking code that uses the `ink` library itself because it changes the way an internal event is managed. The breaking change in `ink-testing-library` is because...
> Although I was thinking that [useStdin](https://github.com/vadimdemedes/ink#usestdin) users might see this as a breaking change, since stdin would emit data events. Yeah I understand this. It mostly depends on what...
Also, according to the [docs](https://nodejs.org/api/stream.html#event-data) the `data` event will still be emitted when we call `stream.read()`, so anyone subscribing to that event won't have any breaking change. The problem in...
@vadimdemedes strangely with [this fix](https://github.com/vadimdemedes/ink/pull/609/commits/178a873f36c8fd0e038701b115e3f73318e62718), tests pass locally if I run `CI=true npm run test`, but they don't seem to pass on CI. The reason for that fix is that...
@DaniGuardiola unfortunately I haven't had the time to continue on this bug, the issue as I left it was one with tests. The code was working fine. CI is failing...
Hi @madelacerda, what is the content of package.json inside `frontend`?
That seems to be the package.json inside `web`, but what about `web/frontend`? I see in the Dockerfile we copy `web` in `.` so `frontend` should become something you can `cd`...