Matteo Bachetti

Results 201 comments of Matteo Bachetti

@Sauravroy34: to make a proper rebase and squash, I suggest the following: ``` git fetch upstream git rebase -i upstream/main ``` + In the editor that appears, mark all commits...

@Sauravroy34 you didn't accept any of my suggested changes, and after the rebase there are more commits than before 😅

@Sauravroy34 it might be quicker, yes. No worries, and thanks for the contribution!

Hello @spranav1205, thanks a lot for your contribution! Although this solution is pretty neat, I think there is a leaner solution to this, that we use in other parts of...

@spranav1205 there is a small remaining issue that makes some tests fail, do you thing you can address it? Also, small thing: the PR is missing a changelog entry. Please...

@spranav1205 If I read this correctly, the `ax` argument is not used inside fold_events, so it was probably a mistake to have it there in the first place, and your...

@spranav1205 one last request: a test that the error is really raised, to be added to `test_search.py`. Something like ``` def test_search_wrongk_key_fails(self): with pytest.raises(ValueError, match="Unidentified keys: "): fold_events(..., fdot=4) ```...

@matteolucchini1 thanks for the review! I will work on the API docs, I do realize now that I could have done much better 😅 . I'm just not sure about...

@matteolucchini1 I wrote a small motivation tutorial here: https://github.com/StingraySoftware/notebooks/pull/107

Hello @abigailStev @jdswinbank @mgullik @matteolucchini1 @eleonorav89 @theand9 @Gaurav17Joshi @pupperemeritus @francescodoan @swapsha96 @mihirtripathi97 @dhruv9vats This paper describes the work done since the first JOSS paper in 2019. You are listed as...