StingraySoftware
Improve stingray.simulator docs
Hi @Sauravroy34 , thanks for the PR, I like how you documented the function. Please run black on the code so that the test passes, it's almost certainly because of a line longer than 100 characters.
Hi @Sauravroy34 , thanks for the PR, I like how you documented the function. Please run
blackon the code so that the test passes, it's almost certainly because of a line longer than 100 characters.
sure , I forgot about that one
@Sauravroy34 for some reason the Squash and Merge button does not appear. Would you mind squashing all commits into one? Sorry for the inconvenience
@Sauravroy34: to make a proper rebase and squash, I suggest the following:
git fetch upstream
git rebase -i upstream/main
-
In the editor that appears, mark all commits but the first with "s" or "squash"; save
-
In the other editor that appears, edit the single commit message, making it meaningful; save
Finally:
git push --force-with-lease
@Sauravroy34: to make a proper rebase and squash, I suggest the following:
git fetch upstream git rebase -i upstream/main
- In the editor that appears, mark all commits but the first with "s" or "squash"; save
- In the other editor that appears, edit the single commit message, making it meaningful; save
Finally:
git push --force-with-lease
Thanks for helping me out !, can you please verify if I squashed it correctly ?
@Sauravroy34 you didn't accept any of my suggested changes, and after the rebase there are more commits than before 😅
@Sauravroy34 you didn't accept any of my suggested changes, and after the rebase there are more commits than before 😅
sorry for any inconvenience I have caused shall I close this one and open another pull request ?
@Sauravroy34 it might be quicker, yes. No worries, and thanks for the contribution!