Matt Dahl
Matt Dahl
Relinking my old PR on this: https://github.com/freelawproject/courtlistener/pull/1226 On the parsing side, I think this may be as simple as allowing "__" to be a valid page number here: https://github.com/freelawproject/eyecite/blob/master/eyecite/utils.py#L31
@bbernicker I was just reviewing this PR in light of #144 and the changes made to `courts-db` in [#135 (comment)](https://github.com/freelawproject/eyecite/issues/135#issuecomment-1404139512). I think your proposed change is still appropriate and necessary,...
> Ideally, I guess we would expect the reporter to be corrected before writing it in the groups. The `Citation.groups` dict is set on init to the content of the...
> @mattdahl thanks for the explanation. I don't see why it would not be possible to "correct" the reporter in the [**post_init**](https://github.com/freelawproject/eyecite/blob/main/eyecite/models.py#L79) function just after self.groups is set, but modifying...
Ah, interesting! It does seem to make sense to me that the hashes should be reproducible across runs. The `hashlib` module (part of the standard library, right?) seems reasonable to...
> By the way, what do you think of the corner cases of the corrected_citation ? Any chance that we get them fixed in the near future ? You mean...
Want me to rebase this?
Thanks for merging that other PR, @flooie. I just rebased this one as well. N.B., I previously suggested that #129 had been made obsolete by intervening changes. This is false....
Just chiming in here since I saw your PR (#136) and was surprised that this wasn't already possible! Thanks for implementing it! Separate from your changes in the PR, I...
Here's a gist doing that collision test: https://gist.github.com/mattdahl/a563a48ac512275d893907dd19acd4ae It doesn't seem that removing whitespace causes any additional collisions, so I think we can safely do that. However, the fact that...