Matt Currie

Results 21 comments of Matt Currie

IIRC, bit 0 remains readable and writable after the boot ROM has finished, but no longer has any effect.

These apply after the boot ROM has finished: - For CGB running in DMG mode, it should read $FF and reads and writes are ignored. - For CGB running in...

Hi, The symbol file support in mgbdis is based on a combination of the output of RGBDS, some custom magic/reserved labels, and Nocash's documentation here: https://problemkaputt.de/gbahlp.htm#symbolicdebuginfo

Hey, sorry just saw this PR! I think it would be great to include the abililty to add comments to the disassembly. Do you have any ideas how we might...

Thanks @anmart, this is looking good! I agree with @ISSOtm, it would be nice if these were available as separate flags. Perhaps there could be a `--theme` (?) arg which...

Yes, `--preset` sounds fine instead of `--theme`. The `--style param=name` idea sounds good, as long its possible to coerce `argparse` (or something else?) - to support that style of argument....

Looks like everything except `--output-dir`, `--overwrite` and `--debug` are style flags. All the others can be moved to the `flag=value` style arguments. I'm not sure about whether grandfathering the old...

Insetad of `nargs='+'`, could use `action='append'` to allow multiple separate `--style` options to be provided, or otherwise let style accept a comma separated list of style arguments?

Yes, absolutely! Super Mario Land is the very first game I created a save state patch for, so DX must have a patch too :) I've now created and uploaded...

@Espio419 I've just double checked applying the patch and seems to be working fine here. Note you will need to apply the save state patch to a working Super Mario...