Matt Brictson
Matt Brictson
> Any updates on this one? xray-rails is breaking on ruby 3.0 I'm using this branch on a Ruby 3.0.0 project and it seems to work. I am reluctant to...
Thanks for the PR! I left some initial comments. I won't be able to approve or merge this PR until we get Travis CI working. @brentd or @TylerRick do you...
I manually restarted the Travis CI build and it seems to be working now 🤔
@TylerRick This is failing CI because CI is testing against Rails < 6. I think the appropriate next steps are: 1. Open a separate PR to add Rails 6 to...
Thanks for the PR. I don't think this is the right approach because `local_config` is for configuration that is developer-specific, not project-specific (e.g. their preferred code editor). Reusing `local_config` for...
Hi, thanks for the report! To be honest, I've never used the `xray: false` feature and this is the first time I've been made aware of it (I currently maintain...
Just to be clear: my expectation of this feature based on the README is that passing `xray: false` should still render the view. The only difference should be that the...
So, my understanding is that xray-rails does two different things wrt HTML injection: 1. For every HTTP response, it adds some global markup (e.g. the xray toolbar) and a ``...
Comments are injected using `Xray.augment_template`, which is defined here: https://github.com/brentd/xray-rails/blob/4c050c7a300db3bf750a4961a78d1c0c61c2003c/lib/xray-rails.rb#L81-L93 This happens whenever a view template is rendered, which is accomplished by a monkey patch registered by `engine.rb`, here: https://github.com/brentd/xray-rails/blob/48ae158da4a4742f743c65efe82bd7c4eb555c49/lib/xray/engine.rb#L31-L53
To reiterate: the `xray: false` option is for disabling Xray for a specific partial template. There is no way to disable Xray for an entire response. I will update the...