Matt Welch
Matt Welch
I was able to reproduce and fix the performance issue. I had failed to create the record callback for messages in steady state :( It should be fixed in the...
Hi @chia7712 @fvaleri . My latest commit refactors the use of a warmupStats object and a main stats object in favor of having one stats that covers the whole test...
Hi @chia7712 and @fvaleri. I've made some updates to this PR in my latest commits including some sample output for review. Please let me know if there's anything else I...
My latest commit moves DEFAULT_REPORTING_INTERVAL_MS into Stats and removes the DEBUG print about config.warmupRecords. Please let me know if there are any additional changes needed on this patch. Thanks @chia7712...
@chia7712 @kirktrue I think I've addressed the issues raised, but does anyone have any more input on this patch?
Hi @chia7712 @kirktrue . Does anyone have additional feedback with this PR? There doesn't appear to be any updates needed to docs/ since that archive of documentation doesn't mention the...
Hi @chia7712. I've updated my latest commit with your suggestions and I think it's a bit more readable now. Let me know if anyone has any more feedback.
Hi again @chia7712 :) Just checking in to see if there are any more issues with this patch. Please let me know if there's anything I can do to improve...
Thank you @fvaleri @kirktrue @chia7712 for all your help and support getting this approved!