Michael Matloob
Michael Matloob
I made a change similar to the above: it changes the definition of downgradeOk ``` - downgradeOk := check.version.cmp(go1_21) >= 0 + downgradeOk := check.version.cmp(go1_21) >= 0 && fileVersion.cmp(go1_21) >=...
cc @rsc So it looks like what's happening here is that we start toolchain selection, determine the `minVersion` of `go1.23.0`(https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/toolchain/select.go;l=209;drc=c71b5ff76a1b1d79b53e268b83fb721e0af4614b) then when we call `goInstallVersion` (https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/toolchain/select.go;l=172;drc=c71b5ff76a1b1d79b53e268b83fb721e0af4614b) to determine if we're...
Sounds good! I'd be interested in helping once the duffzero changes are in. Would we be able to only generate the AVX instructions when we compile with GOAMD64=v3+?
@RyanRosario do you have javascript disabled on your browser? The [filename in the instructions served in the original html is for a 1.14.3 archive](https://cs.opensource.google/go/x/website/+/master:_content/doc/install.html;l=83;drc=15db8a6e56d8c31431c243dea63c3299892d9ba9) but we use javascript to [dynamically...
I'm wondering why we don't always set the version even if the OS isn't linux? It seems like this problem could occur if the user user agent doesn't match any...
Adding dedicated support for source rewriting tools would result in a significant increase in complexity in the go command, and also in the interface surface area of the go command...
cc @ianthehat Do you have a perspective on this?
@ianthehat I'm interested to hear (read?) why you think `go mod verify -tag` may not be a good interface for this. @Esra-Al I think if we do use `go mod...
Yeah it sounds like we should make that change. I agree that it's weird to ask for TypesInfo but not Types but that we should honor the request.
@adonovan I think we also need to request the necessary fields for type checking from the driver as is done in @xrxtzz's CL? We should also update the documentation for...