go icon indicating copy to clipboard operation
go copied to clipboard

x/website: linux install instruction version number not updated on chromeos

Open RyanRosario opened this issue 1 year ago • 8 comments

What is the URL of the page with the issue?

https://go.dev/doc/install

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 14541.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36

Screenshot

Screenshot 2024-09-23 7 29 09 PM

What did you do?

I tried to blindly run the command in the first box after downloading the 1.23 go distribution.

What did you see happen?

I got a a no such file or directory error.

Even though the latest version is printed on the blue button, the instructions contained an old version number.

What did you expect to see?

I expected the command to delete any old Go distributions and extract the latest distribution into /usr/local.

I expected the command to contain a version number matching the latest version in the blue button text.

RyanRosario avatar Sep 24 '24 02:09 RyanRosario

@golang/tools-team

dr2chase avatar Sep 26 '24 20:09 dr2chase

@RyanRosario do you have javascript disabled on your browser?

The filename in the instructions served in the original html is for a 1.14.3 archive but we use javascript to dynamically update the file name in the download instructions.

matloob avatar Sep 26 '24 20:09 matloob

@matloob I do not. JavaScript is enabled. I am using Chrome on a Chromebook+. I just visited the site again and it still shows 1.14.3.

RyanRosario avatar Oct 06 '24 02:10 RyanRosario

Maybe ChomeOS / CrOS should be treated as a unix in https://go.dev/doc/download.js

seankhliao avatar Oct 06 '24 11:10 seankhliao

Change https://go.dev/cl/620556 mentions this issue: _content/doc: treat ChromeOS as linux in download selector

gopherbot avatar Oct 16 '24 21:10 gopherbot

I'm wondering why we don't always set the version even if the OS isn't linux? It seems like this problem could occur if the user user agent doesn't match any of the detectOS patterns because the linux tab will be selected by default but the file name won't be updated because the OS isn't set to linux.

matloob avatar Oct 17 '24 14:10 matloob

I was also wondering why there was a unix OS that wouldn't match any download option. I've updated my CL.

seankhliao avatar Oct 17 '24 19:10 seankhliao