Mati Kaczmarek

Results 14 comments of Mati Kaczmarek

We've set ERROR_EMAIL env in HDN repository in this PR: https://github.com/T-CAIREM/tcairem-terraform/pull/27. Now HDN error pages link to `[email protected]`.

> Thanks @matkaczmarek please could you include a full description for the pull request here? I don't think we have access to your issue tracker (or at least if we...

Two questions for @tompollard, @bemoody: - should we implement defaults in views when step details is not available in database such as here(if/else): https://github.com/MIT-LCP/physionet-build/pull/2198/files#diff-4f961161fbbb6291c7505b39816715a53c104e67e49f1d9e90e5e78f5854ea23R40 - class Section and class StepDetails...

> This change looks fine, but the views themselves (`cloud_groups`, `cloud_groups_management`, `create_cloud_group`, `get_datasets_monitoring_data`) don't appear to exist in `hdn-research-environment` version `2.3.8`. Are those planned for the future? Oh, I see...

@tompollard @bemoody please take a look and let me know what you think about making the admin console more customizable.

> > This is where I disagree. I'd say just put them in! Add them to the nav menu in a place that makes sense. > Sure! So, I will...

> We currently have the option to add an ORCID ID to a user's profile. Is it your intention that _someone who has already done that_ should now be able...

> What is validated? What kind of malicious behavior? Please be specific. > > This article seems like a good place to start: https://oauth.net/articles/authentication/ Thanks for a great article. Referring...

Hi @bemoody, after our last call I two changes: - I added `id_token` verification by checking the signature of the ID token using ORCID JSON Web Key Set (ORCID public...

> If somebody's ORCID account was compromised on Monday, and they reset their ORCID password on Tuesday, and they try to log in to PhysioNet using ORCID on Wednesday, how...