Matias Leyba

Results 10 comments of Matias Leyba

@jmagman We will mark this as resolved since we have removed the `Podfile.lock` from the template in the new version [1.0.9](https://brickhub.dev/bricks/flutter_news_template#changelog).

> Thanks for the contribution! In my opinion, this logic doesn't belong in the AppBloc because it's not app-level state. Instead, I propose adding this logic in the ArticleBloc since...

@felangel Got it, no problem. Should we move the PR to draft?

@domesticmouse @felangel I have worked on this PR in other toolkit implementation, so I have the tests fixed and I can collaborate right here, can we push commits on this...

Hi @felangel @marwfair 👋🏻 I have updated this PR by adding `FakeVideoPlayerPlatform` class and setting up `VideoPlayerPlatform.instance` on tests that are using `VideoPlayer` library in order to fix test issues....

> If there is any feedback regarding the naming of the `DeepLinkService` and the updated folder structure for `deep_link_client/`, please let me know 🙌 > > I also ran all...

Hi @elianortega, we have been able to resolve the issues with the CI workflows, would you mind updating the PR? Thanks in advance!

> Hey @matiasleyba sorry for the late reply, > > > reviewing the project again I see that the deep_link_client is very much tied to the email link authentication functionality...

@elianortega As the implementation of the DeepLinkClient class is very much tied to Firebase auth I don't see another use case for this class apart from authentication using a link,...

> If there are no issues with moving towards another navigation approach, I agree that refactoring to use go_router first is the way to go, that would also enable the...