Mathias Lüdtke
Mathias Lüdtke
This is just an intermediate solution. The `*_or_unset` cases should be implemented with proper default values (something like #452).
First step: https://github.com/ros-industrial/industrial_ci/pull/717 I guess a full port does not make too much sense, but some of the heavier tasks could be delegated to Python scripts.
`NOT_TEST_BUILD` and `NOT_TEST_DOWNSTREAM` should deactive the tests entirely, but that's not possible. Therefore `ABORT_ON_TEST_FAILURE_UNDERLAY` and `ABORT_ON_TEST_FAILURE_OVERLAY` can used to opt out
> Why not upload the data at the end of ci_main.sh? ~~Or even inside docker..~~ ~~This would save one volume mount.~~
> Why not upload the data at the end of ci_main.sh? I might be better to take out the upload steps completely and just delegate it to the outer job...
> Is there any way I can help with this. @tylerjw: For now it would be great, if you could test it and give some feedback. @Briancbn: Please rebase your...
If the builds fail randomly (-> not always), then you have a race condition somewhere. And normally, a crash in RVIZ should not make the CI fail, so it might...
Very nice! > The extra mount seems a little bit hacky to me It is not too hacky.. just one of the downside of using Docker (or containers in general)....
I have now added support for mounting the workspaces automatically (https://github.com/ros-industrial/industrial_ci/pull/572). ```yaml test_junit: script: .industrial_ci/gitlab.sh variables: ROS_DISTRO: noetic BASEDIR: ${CI_PROJECT_DIR}/.build artifacts: when: always reports: junit: ${BASEDIR}/**/test_results/**/*.xml ``` (results: https://gitlab.com/ipa-mdl/industrial_ci/-/pipelines/240764976/test_report)
> Currently your changes are available on GitLab only. Is that intended? `BASEDIR` will be available everywhere.. Other CI services might not have the same mount issue, though. >(P.S.: I...