Matt Einhorn
Matt Einhorn
I'm hoping to start working on this again this week! 🤞
Originally, when I looked at it, I saw 3 options. The original scipy, `TorchIO`, and `monai`. 1. scipy didn't seem to do true 3d transformations - rather it treated a...
1. I still need to add some tests, and maybe a little docs here and there. 2. I removed `monai` from the dependencies and manually install them with `pip install...
The reason for the tests failing is that it times out because it takes too long (60 min). As mentioned in the todos, there are a lot of tests and...
No worries at all! I responded about g-node here: https://github.com/brainglobe/cellfinder/issues/439. About skipping slow tests. I think we can classify slow (and not *as* essential) and normal tests using a mark....
It now uses a smaller brain for the bright brain. With cache it seems to take around 12 min and without cache upto 30min. Perhaps increasing to timeout to 2...
Thank *you* for taking the time reviewing the giant PR 🙂 The other requested code changes I'll do ASAP.
The reason why it fails on Windows on the CI is due to https://github.com/pytorch/pytorch/issues/131958. It's an issue with pytorch 2.4.0. I think we may need to pin pytorch (max) versions...
I don't have any objections. I am mainly worried about people trying to use it without the full API being in place. But I guess people who use `main` without...
Rebased on https://github.com/brainglobe/cellfinder/pull/542, squashed, and moved new params to the end of functions.